Adding learn more links to primary and secondary pages. #998
Conversation
|
@jwforres PTAL |
|
We've switch to "Learn More" with an uppercase M |
| @@ -10,7 +10,13 @@ | |||
| <div class="pull-right" ng-if="project && ('configmaps' | canI : 'create')"> | |||
| <a ng-href="project/{{project.metadata.name}}/create-config-map" class="btn btn-default">Create Config Map</a> | |||
| </div> | |||
| <h1>Config Maps</h1> | |||
| <h1>Config Maps | |||
There was a problem hiding this comment.
Formatting nit: When there are other elements inside the header, I find it much easier to read if the header text is on the next line...
<h1>
Config Maps
<span>...</span>
</h1>| <h1>Config Maps | ||
| <span class="page-header-link"> | ||
| <a ng-href="{{'config-maps' | helpLink}}" target="_blank"> | ||
| Learn more <i class="fa fa-external-link" aria-hidden="true"></i> |
There was a problem hiding this comment.
Probably should use a non-breaking space between the text and icon so that the icon doesn't ever wrap by itself. It could break on some longer headers at mobile.
There was a problem hiding this comment.
I set the wrapping span to whitespace: no-wrap and inline-block so it wouldn't wrap separately.
sg00dwin
force-pushed
the
learn-more-issue946
branch
2 times, most recently
from
5801832
to
01d3fdf
Compare
|
[merge] |
sg00dwin
force-pushed
the
learn-more-issue946
branch
from
01d3fdf
to
022f3ee
Compare
|
@spadgett updated based on your feedback. |
|
[merge] |
|
Evaluated for origin web console merge up to 022f3ee |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/823/) (Base Commit: c9b7feb) |
Fixes #946
Moved .page-header styles, along with several other misc rules, from _core.less to _typeography.less
Also fixes openshift/origin#7664