Skip to content

Commit

Permalink
Skip the oc whoami --show-console test when the console capability is…
Browse files Browse the repository at this point in the history
… disabled
  • Loading branch information
bparees committed Jan 24, 2023
1 parent 2154d73 commit 118d288
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
6 changes: 4 additions & 2 deletions test/extended/cli/basics.go
Expand Up @@ -247,10 +247,12 @@ var _ = g.Describe("[sig-cli] oc basics", func() {
o.Expect(err).NotTo(o.HaveOccurred())
found := serverPattern.MatchString(out)
o.Expect(found).To(o.BeTrue())
})

out, err = oc.Run("whoami").Args("--show-console").Output()
g.It("can show correct whoami result with console", func() {
out, err := oc.Run("whoami").Args("--show-console").Output()
o.Expect(err).NotTo(o.HaveOccurred())
found = consolePattern.MatchString(out)
found := consolePattern.MatchString(out)
o.Expect(found).To(o.BeTrue())
})
})

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions test/extended/util/annotate/rules.go
Expand Up @@ -332,6 +332,8 @@ var (
// this list needs to be refined as there are some storage tests we should be able to run.
// Tracker for enabling more storage tests: https://issues.redhat.com/browse/OCPPLAN-9509
`\[sig-storage\]`,
// This test requires a valid console url which doesn't exist when the optional console capability is disabled.
`\[sig-cli\] oc basics can show correct whoami result with console`,
},
}
)

0 comments on commit 118d288

Please sign in to comment.