properly handle object creation error in template instantiate

https://bugzilla.redhat.com/show_bug.cgi?id=1661845
openshift · Dec 24, 2018 · 5ba7b56 · 5ba7b56
1 parent 85a0623
commit 5ba7b56
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 1 deletion.
diff --git a/pkg/template/controller/templateinstance_controller.go b/pkg/template/controller/templateinstance_controller.go
@@ -501,7 +501,7 @@ func (c *TemplateInstanceController) instantiate(templateInstance *templatev1.Te
 			}
 		}
 		if createErr != nil {
-			allErrors = append(allErrors, mappingErr)
+			allErrors = append(allErrors, createErr)
 			continue
 		}
 

diff --git a/test/extended/testdata/bindata.go b/test/extended/testdata/bindata.go