deploy: set background propagation policy for old deployment cleanup

openshift · May 22, 2017 · 8ca79b0 · 8ca79b0
1 parent aa35b69
commit 8ca79b0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/deploy/controller/deploymentconfig/deploymentconfig_controller.go b/pkg/deploy/controller/deploymentconfig/deploymentconfig_controller.go
@@ -7,6 +7,7 @@ import (
 	"github.com/golang/glog"
 
 	kapierrors "k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	kutilerrors "k8s.io/apimachinery/pkg/util/errors"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
@@ -428,7 +429,10 @@ func (c *DeploymentConfigController) cleanupOldDeployments(existingDeployments [
 			continue
 		}
 
-		err := c.rn.ReplicationControllers(deployment.Namespace).Delete(deployment.Name, nil)
+		policy := metav1.DeletePropagationBackground
+		err := c.rn.ReplicationControllers(deployment.Namespace).Delete(deployment.Name, &metav1.DeleteOptions{
+			PropagationPolicy: &policy,
+		})
 		if err != nil && !kapierrors.IsNotFound(err) {
 			deletionErrors = append(deletionErrors, err)
 		}