always flush glog before returning from build logic

openshift · Mar 11, 2016 · 9478e43 · 9478e43
1 parent 36b80cb
commit 9478e43
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/build/builder/docker.go b/pkg/build/builder/docker.go
@@ -105,6 +105,7 @@ func (d *DockerBuilder) Build() error {
 		glog.Warningf("Failed to remove temporary build tag %v: %v", buildTag, err)
 	}
 
+	defer glog.Flush()
 	if push {
 		// Get the Docker push authentication
 		pushAuthConfig, authPresent := dockercfg.NewHelper().GetDockerAuth(

diff --git a/pkg/build/builder/sti.go b/pkg/build/builder/sti.go
@@ -246,6 +246,7 @@ func (s *S2IBuilder) Build() error {
 		glog.Warningf("Failed to remove temporary build tag %v: %v", buildTag, err)
 	}
 
+	defer glog.Flush()
 	if push {
 		// Get the Docker push authentication
 		pushAuthConfig, authPresent := dockercfg.NewHelper().GetDockerAuth(
@@ -274,7 +275,6 @@ func (s *S2IBuilder) Build() error {
 			return errors.New(msg)
 		}
 		glog.Infof("Successfully pushed %s", pushTag)
-		glog.Flush()
 	}
 	return nil
 }