Skip to content

Commit

Permalink
Merge pull request #28627 from dgoodwin/ignore-loki-alerts
Browse files Browse the repository at this point in the history
TRT-1539: Do not let loki alerts fail tests
  • Loading branch information
openshift-merge-bot[bot] committed Feb 29, 2024
2 parents 6ec17d7 + e38745d commit bb34cbc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/extended/prometheus/prometheus.go
Expand Up @@ -551,7 +551,8 @@ var _ = g.Describe("[sig-instrumentation] Prometheus [apigroup:image.openshift.i
}

tests := map[string]bool{
fmt.Sprintf(`ALERTS{alertname!~"%s",alertstate="firing",severity!="info"} >= 1`, strings.Join(allowedAlertNames, "|")): false,
// openshift-e2e-loki alerts should never fail this test, we've seen this happen on daemon set rollout stuck when CI loki was down.
fmt.Sprintf(`ALERTS{alertname!~"%s",alertstate="firing",severity!="info",namespace!="openshift-e2e-loki"} >= 1`, strings.Join(allowedAlertNames, "|")): false,
}
err := helper.RunQueries(context.TODO(), oc.NewPrometheusClient(context.TODO()), tests, oc)
o.Expect(err).NotTo(o.HaveOccurred())
Expand Down

0 comments on commit bb34cbc

Please sign in to comment.