Skip to content

Commit

Permalink
Remove the display bool for now, will re-add in another PR as it fail…
Browse files Browse the repository at this point in the history
…s tests
  • Loading branch information
dgoodwin committed Oct 20, 2023
1 parent 747fd09 commit dc3c6fc
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions pkg/monitor/serialization/serialize.go
Expand Up @@ -21,8 +21,7 @@ type EventInterval struct {

// TODO: Remove the omitempty, just here to keep from having to repeatedly updated the json
// files used in some new tests
Source string `json:"tempSource,omitempty"` // also temporary, unsure if this concept will survive
Display bool `json:"display"`
Source string `json:"tempSource,omitempty"` // also temporary, unsure if this concept will survive

// TODO: we're hoping to move these to just locator/message when everything is ready.
StructuredLocator monitorapi.Locator `json:"tempStructuredLocator"`
Expand Down Expand Up @@ -65,8 +64,7 @@ func IntervalsFromJSON(data []byte) (monitorapi.Intervals, error) {
return nil, err
}
events = append(events, monitorapi.Interval{
Source: monitorapi.IntervalSource(interval.Source),
Display: interval.Display,
Source: monitorapi.IntervalSource(interval.Source),
Condition: monitorapi.Condition{
Level: level,
Locator: interval.Locator,
Expand All @@ -93,8 +91,7 @@ func IntervalFromJSON(data []byte) (*monitorapi.Interval, error) {
return nil, err
}
return &monitorapi.Interval{
Source: monitorapi.IntervalSource(serializedInterval.Source),
Display: serializedInterval.Display,
Source: monitorapi.IntervalSource(serializedInterval.Source),
Condition: monitorapi.Condition{
Level: level,
Locator: serializedInterval.Locator,
Expand Down Expand Up @@ -166,7 +163,6 @@ func monitorEventIntervalToEventInterval(interval monitorapi.Interval) EventInte
StructuredLocator: interval.StructuredLocator,
StructuredMessage: interval.StructuredMessage,
Source: string(interval.Source),
Display: interval.Display,

From: metav1.Time{Time: interval.From},
To: metav1.Time{Time: interval.To},
Expand Down

0 comments on commit dc3c6fc

Please sign in to comment.