Skip to content

Commit

Permalink
fix up ruby-25-centos7 tag check logic
Browse files Browse the repository at this point in the history
  • Loading branch information
bparees committed Dec 18, 2019
1 parent fe19c11 commit e1f630e
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 20 deletions.
13 changes: 9 additions & 4 deletions examples/sample-app/application-template-dockerbuild.json
Expand Up @@ -86,10 +86,15 @@
"name": "ruby-25-centos7"
},
"spec": {
"dockerImageRepository": "centos/ruby-25-centos7"
},
"status": {
"dockerImageRepository": ""
"tags": [
{
"from": {
"kind": "DockerImage",
"name": "docker.io/centos/ruby-25-centos7:latest"
},
"name": "latest"
}
]
}
},
{
Expand Down
29 changes: 19 additions & 10 deletions test/extended/testdata/bindata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions test/extended/testdata/cmd/test/cmd/builds.sh
Expand Up @@ -77,8 +77,7 @@ os::cmd::expect_success 'oc get bc'
os::cmd::expect_success 'oc get builds'

# make sure the imagestream has the latest tag before trying to test it or start a build with it
# TODO: (bparees): Uncomment this when this line stop timing out
# os::cmd::try_until_text 'oc get is ruby-25-centos7' 'latest'
os::cmd::try_until_success 'oc get istag ruby-25-centos7:latest'

os::test::junit::declare_suite_start "cmd/builds/patch-anon-fields"
REAL_OUTPUT_TO=$(oc get bc/ruby-sample-build --template='{{ .spec.output.to.name }}')
Expand Down
Expand Up @@ -86,10 +86,15 @@
"name": "ruby-25-centos7"
},
"spec": {
"dockerImageRepository": "centos/ruby-25-centos7"
},
"status": {
"dockerImageRepository": ""
"tags": [
{
"from": {
"kind": "DockerImage",
"name": "docker.io/centos/ruby-25-centos7:latest"
},
"name": "latest"
}
]
}
},
{
Expand Down

0 comments on commit e1f630e

Please sign in to comment.