Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gopass for password input #10737

Closed
fabianofranz opened this issue Aug 31, 2016 · 5 comments
Closed

Use gopass for password input #10737

fabianofranz opened this issue Aug 31, 2016 · 5 comments
Assignees
@fabianofranz
Labels
area/techdebt component/cli kind/post-rebase priority/P2

Comments

@fabianofranz
Copy link
Member

We must be consistent with upstream in kubernetes/kubernetes#31586 and use github.com/howeyc/gopass for masked password input.
@fabianofranz
Copy link
Member Author

Affected command: oc login.

@fabianofranz fabianofranz mentioned this issue Aug 31, 2016
Merged
@liggitt
Copy link
Contributor

liggitt commented Aug 31, 2016

we don't currently echo the password to the terminal... do we need to pull in the dependency?

@fabianofranz
Copy link
Member Author

@liggitt gopass adds masked input with *, I think that's better UX.

@liggitt
Copy link
Contributor

liggitt commented Aug 31, 2016

It leaks number of characters in the password. sudo su doesnt echo *

@liggitt
Copy link
Contributor

liggitt commented Sep 28, 2016

I'm slightly -1 on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianofranz fabianofranz

Labels
area/techdebt component/cli kind/post-rebase priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabianofranz @liggitt