When prompting for passwords, don't echo to the terminal

[brendandburns]

@deads2k
@kubernetes/kubectl

---

This change is

[jwforres]

cc @fabianofranz

[brendandburns]

@k8s-bot test this please issue: #23634

[fabianofranz]

@brendandburns We are just using DisableEcho from docker/pkg/term like in here. Other than masked input, does gopass add anything that Docker's term doesn't provide? Looks pretty solid, it's just that I never heard of it before.

[brendandburns]

@fabianofranz it masks the characters, so that you get:

Enter Password: *******

Instead of

Enter Password:

Given that we don't currently vendor that Docker library, and that feature I'd just as soon use this library.

Thanks!
--brendan

[deads2k]

Given that we don't currently vendor that Docker library, and that feature I'd just as soon use this library.

Ok.

[deads2k]

lgtm.

@fabianofranz we should probably be consistent downstream. If you tag an issue in origin kind/post-rebase it ought to percolate up after the next kube rebase.

[fabianofranz]

@brendandburns works for me, thanks! LGTM

@deads2k definitely, added openshift/origin#10737

[k8s-bot]

GCE e2e build/test passed for commit 7de9bc6.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-bot]

GCE e2e build/test passed for commit 7de9bc6.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-github-robot]

Automatic merge from submit-queue