Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty the pool, or delete the pool when endpoints are deleted #11940

Merged
merged 1 commit into from
Nov 17, 2016
Merged

empty the pool, or delete the pool when endpoints are deleted #11940

merged 1 commit into from
Nov 17, 2016

Conversation

rajatchopra
Copy link
Contributor

bz: https://bugzilla.redhat.com/show_bug.cgi?id=1395545

The pool was never getting deleted on a 'delete' event.

@rajatchopra
Copy link
Contributor Author

[test]

@rajatchopra
Copy link
Contributor Author

@ramr
@openshift/networking

@knobunc
Copy link
Contributor

knobunc commented Nov 16, 2016

@rajatchopra can you make the commit message include:
bug 1395545

That is what the bot looks for that update BZ. It's a rather hostile format for humans, so I prefer to say something like:
Fixes bug 1395545 [link](https://bugzilla.redhat.com/show_bug.cgi?id=1395545)

Thanks

knobunc
knobunc approved these changes Nov 16, 2016
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes bug 1395545 [link](https://bugzilla.redhat.com/show_bug.cgi?id=…
b1d8e0b 
…1395545)

empty the pool, or delete the pool when endpoints are deleted
@knobunc
Copy link
Contributor

knobunc commented Nov 16, 2016

[test] flake #11016

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b1d8e0b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11503/) (Base Commit: 3712aec)

@ramr
Copy link
Contributor

ramr commented Nov 16, 2016

LGTM

pravisankar
pravisankar approved these changes Nov 16, 2016
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knobunc
Copy link
Contributor

knobunc commented Nov 17, 2016

[merge]

@rajatchopra we'll need to cherry pick over to 1.4.

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to b1d8e0b

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 17, 2016 •
edited

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11527/) (Base Commit: 266bc63) (Image: devenv-rhel7_5378)

@openshift-bot openshift-bot merged commit a631fd3 into openshift:master Nov 17, 2016
knobunc added a commit to knobunc/origin that referenced this pull request Nov 17, 2016
@knobunc
Cherry-pick of openshift#11940 by @rajatchopra
7684960 
(commit a631fd3)

Fixes bug 1395545 (https://bugzilla.redhat.com/show_bug.cgi?id=1395545)
@knobunc knobunc mentioned this pull request Nov 17, 2016
Merged
@rajatchopra rajatchopra deleted the f5_deletepool branch December 16, 2016 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar approved these changes

@knobunc knobunc knobunc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajatchopra @knobunc @openshift-bot @ramr @pravisankar