Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: empty the pool, or delete the pool when endpoints are deleted #11956

Merged

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Nov 17, 2016

Cherry-pick of #11940 by @rajatchopra (commit a631fd3)

Fixes bug 1395545 (https://bugzilla.redhat.com/show_bug.cgi?id=1395545)

@knobunc
Copy link
Contributor Author

knobunc commented Nov 17, 2016

[test] @openshift/networking @rajatchopra PTAL

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7684960

@knobunc knobunc changed the title Cherry-pick of https://github.com/openshift/origin/pull/11940 Cherry-pick: empty the pool, or delete the pool when endpoints are deleted Nov 17, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11536/) (Base Commit: 3712aec)

Copy link
Contributor

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested, it works. Amazing piece of code.
Cash bonus for the author :).

@knobunc
Copy link
Contributor Author

knobunc commented Nov 17, 2016

👍 [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 17, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11536/) (Image: devenv-rhel7_5380)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7684960

@openshift-bot openshift-bot merged commit b4e0954 into openshift:release-1.4 Nov 17, 2016
@knobunc knobunc deleted the cp/11940-f5-service-delete branch June 7, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants