Fix stub interface so Mac compilations work #12720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stub "unsupported" interface had the wrong signature. This corrects it to prevent a compilation error on Macs. Fixes bug 1417747 https://bugzilla.redhat.com/show_bug.cgi?id=1417747
knobunc
force-pushed
the
bug/bz1417747-fix-mac-compile
branch
from
b0d4753
to
b9dcb9f
Compare
|
@openshift/networking PTAL No point in testing because the cross-compilation isn't tested. |
|
(This is fallout from #12650.) [merge] |
|
You can ask someone with a Mac to test :) |
|
@smarterclayton I don't know anyone with a Mac, do you have a suspect in mind? |
|
Evaluated for origin merge up to b9dcb9f |
|
[Test]ing while waiting on the merge queue |
|
What a coincidence - I do! Worked for me :) |
|
@tdawson FYI |
|
Evaluated for origin test up to b9dcb9f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13420/) (Base Commit: fe1f9cc) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13430/) (Base Commit: 488e6f1) (Image: devenv-rhel7_5817) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stub "unsupported" interface had the wrong signature. This
corrects it to prevent a compilation error on Macs.
Fixes bug 1417747 https://bugzilla.redhat.com/show_bug.cgi?id=1417747