oc rsync fails if 'oc' command has space in it's path

[robstryker]

[provide a description of the issue]

Version

[provide output of the openshift version or oc version command]
oc 3.3.1.5 and oc 3.5.5.5

Steps To Reproduce

1. [step 1] copy 'oc' command to a folder with spaces in it
2. [step 2] use full path to call that oc command, and call oc rsync. ex:

home/rob/tmp/with\ spaces/oc rsync --token=xxx --server=https://192.168.99.100:8443 --insecure-skip-tls-verify=true --exclude='.git' eap-app-1-qpldm:/opt/eap/standalone/deployments/ -n myproj /home/rob/apps/eclipse/workspaces/runtime-New_configuration/.metadata/.plugins/org.jboss.ide.eclipse.as.core/myproj@eap-app/deploy/

Current Result

rsync: Failed to exec /home/rob/tmp/with: No such file or directory (2)
rsync error: error in IPC code (code 14) at pipe.c(85) [Receiver=3.1.2]
rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
rsync error: error in IPC code (code 14) at io.c(226) [Receiver=3.1.2]
error: exit status 14

Expected Result

The rsync occurs as expected

Additional Information

Hardy thinks the problem may be here:
https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/copyrsync.go#L37

The oc command calls rsync and passes in the "OpenShift CLI rsh command as the remote shell command for rsync". This is obviously failing hard because of the spaces. rsync thinks only the first part of the 'oc' command's path (pre space) is the command to call.

This code may need to ensure that the 'oc' command's spaces are properly escaped.

The issue may be in SiblingCommand:

origin/pkg/cmd/util/sibling.go

Line 12 in 85eb37b

func SiblingCommand(cmd *cobra.Command, name string) string {

Either way, when passing the 'oc' command into rsync, it is not accounting for spaces.

[robstryker]

I cannot figure out how to add an cli/rsync label to this...

[robstryker]

It's worth noting here that the following commands DO work as expected:

/home/rob/tmp/with\ spaces/oc status
/home/rob/tmp/with\ spaces/oc login
/home/rob/tmp/with\ spaces/oc get pods

etc etc etc. Everything functions as normal except the rsync.

[robstryker]

related issue: https://issues.jboss.org/browse/JBIDE-23862

[bparees]

unless i'm missing something, you can work around this by running oc from another dir (and still pointing to the same source dir for the rsync), right?

[robstryker]

Moving 'oc' to a folder that does not have a space in its path is a valid workaround. And I'll admit I don't know at all (plus or minus) which of our workflows may be installing oc in a path with spaces, or allow users to choose, or anything. I simply have no data on that at this time...

It might also be a workaround to just make a symlink (but I haven't tried it yet ;)) ... so there are workarounds, but, we need to know if our tools should TRY to allow paths with spaces, or if we should ban it outright for the time being.

[bparees]

it's a bug and we'll fix it, i'm just trying to assess the urgency. I can't promise it's going to make the 3.6 release and it doesn't sound like something we'd backport to 3.5, so i think you will want to consider trying to handle it in your tooling.

[robstryker]

Thanks for the candid update. That gives me some good guidance to work with.

[adietish]

@coreydaley thx for fixing this. Is there any plan to backport it to existing versions?

[coreydaley]

@adietish not that I am aware of

[adietish]

@coreydaley ok, can you then please point me to the version of oc this will be included in?