Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBAC Migration Followup #24: Update RoleBindingRestriction admission to handle RBAC #16042

Closed
enj opened this issue Aug 29, 2017 · 0 comments
Closed

RBAC Migration Followup #24: Update RoleBindingRestriction admission to handle RBAC #16042

enj opened this issue Aug 29, 2017 · 0 comments
Assignees
@simo5
Labels
area/security area/techdebt area/tests component/auth kind/delivery-blocker priority/P1 sig/security
Milestone
v3.7

Comments

@enj
Copy link
Contributor

enj commented Aug 29, 2017 •
edited

The admission plugin at pkg/authorization/admission/restrictusers/restrictusers.go:97 needs to updated to prevent the creation of RBAC role bindings. This is critical for online environments since they use this feature heavily. We need to add tests for this as well. I do not think we can drop the legacy bits in the code either (could cause issues during a HA upgrade).

@openshift/sig-security @Miciah @jupierce @sdodson
@enj enj added this to the 3.7.0 milestone Aug 29, 2017
@simo5 simo5 mentioned this issue Aug 29, 2017
Merged
67 tasks
@pweil- pweil- added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 1, 2017
@simo5 simo5 removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 5, 2017
This was referenced Sep 6, 2017
Merged
Closed
openshift-merge-robot added a commit that referenced this issue Sep 9, 2017
@openshift-merge-robot
Merge pull request #16163 from simo5/updateRBR
2a02f4b 
Automatic merge from submit-queue

Update RoleBindingRestriction admission to handle RBAC

Fixes #16042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simo5 simo5

Labels
area/security area/techdebt area/tests component/auth kind/delivery-blocker priority/P1 sig/security
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
3 participants
@pweil- @enj @simo5