Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow baremetal tests to run on GCP platform #27618

Merged
merged 1 commit into from Feb 11, 2023

Conversation

elfosardo
Copy link
Contributor

Metal3 pods can now be deployed on GCP platform.
Baremetal hosts can be booted only via virtual media. We only check for the presence of the metal3 pod to verify the baremetal deployment is available in GCP too.

@elfosardo
Copy link
Contributor Author

/hold wait for openshift/cluster-baremetal-operator#316 to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2022
@elfosardo
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@elfosardo
Copy link
Contributor Author

@deads2k hi! Please have a look at this when you get a chance, thanks!

@elfosardo
Copy link
Contributor Author

/cc @deads2k

@openshift-ci openshift-ci bot requested a review from deads2k February 7, 2023 08:56
Metal3 pods can now be deployed on GCP platform.
Baremetal hosts can be booted only via virtual media.
We only check for the presence of the metal3 pod to verify the
baremetal deployment is available in GCP too.
@elfosardo
Copy link
Contributor Author

/cc @dtantsur

@openshift-ci openshift-ci bot requested a review from dtantsur February 8, 2023 09:16
@elfosardo
Copy link
Contributor Author

/retest

2 similar comments
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 1b6d567 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 1b6d567 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 1b6d567 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node 1b6d567 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-azure-ovn-etcd-scaling 1b6d567 link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Contributor Author

/cc @sadasu @bparees

@elfosardo
Copy link
Contributor Author

/cc @derekhiggins @honza @iurygregory

@elfosardo
Copy link
Contributor Author

this is similar to #27569
tests look ok, failures do not depend from this change

@derekhiggins
Copy link
Contributor

Looking at "pull-ci-openshift-origin-master-e2e-gcp-ovn" I see the job is skipped, is this expected due to cluster config?

started: 0/284/418 "[sig-installer][Feature:baremetal] Baremetal/OpenStack/vSphere/None/AWS/GCP platforms [apigroup:config.openshift.io] have a metal3 deployment [Suite:openshift/conformance/parallel]"
skip [github.com/openshift/origin/test/extended/baremetal/common.go:55]: Unsupported config in supported platform detected
Ginkgo exit error 3: exit with code 3
skipped: (4.3s) 2023-02-09T09:55:53 "[sig-installer][Feature:baremetal] Baremetal/OpenStack/vSphere/None/AWS/GCP platforms [apigroup:config.openshift.io] have a metal3 deployment [Suite:openshift/conformance/parallel]"

@elfosardo
Copy link
Contributor Author

Looking at "pull-ci-openshift-origin-master-e2e-gcp-ovn" I see the job is skipped, is this expected due to cluster config?

started: 0/284/418 "[sig-installer][Feature:baremetal] Baremetal/OpenStack/vSphere/None/AWS/GCP platforms [apigroup:config.openshift.io] have a metal3 deployment [Suite:openshift/conformance/parallel]"
skip [github.com/openshift/origin/test/extended/baremetal/common.go:55]: Unsupported config in supported platform detected
Ginkgo exit error 3: exit with code 3
skipped: (4.3s) 2023-02-09T09:55:53 "[sig-installer][Feature:baremetal] Baremetal/OpenStack/vSphere/None/AWS/GCP platforms [apigroup:config.openshift.io] have a metal3 deployment [Suite:openshift/conformance/parallel]"

@derekhiggins yes that's expected

@bparees
Copy link
Contributor

bparees commented Feb 10, 2023

/approve

but this is going to merge conflict with #27573 i believe

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@derekhiggins
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, derekhiggins, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d683bcc into openshift:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants