Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow baremetal tests to run on Azure platform #27573

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Allow baremetal tests to run on Azure platform #27573

merged 1 commit into from
Feb 15, 2023

Conversation

elfosardo
Copy link
Contributor

Metal3 pods can now be deployed on Azure platform. Baremetal hosts can be booted only via virtual media. We only check for the presence of the metal3 pod to verify the baremetal deployment is available in Azure too.

@elfosardo elfosardo marked this pull request as draft November 28, 2022 13:47
@elfosardo elfosardo changed the title Allow baremetal tests to run on Azure platform [WIP] Allow baremetal tests to run on Azure platform Nov 28, 2022
@elfosardo
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 28, 2022
@elfosardo
Copy link
Contributor Author

/test e2e-azure

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@elfosardo
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@elfosardo elfosardo changed the title [WIP] Allow baremetal tests to run on Azure platform Allow baremetal tests to run on Azure platform Nov 29, 2022
@elfosardo elfosardo marked this pull request as ready for review November 29, 2022 13:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@elfosardo
Copy link
Contributor Author

/test e2e-azure

@openshift-ci openshift-ci bot requested a review from sttts November 29, 2022 13:49
@elfosardo
Copy link
Contributor Author

hold until openshift/cluster-baremetal-operator#309 merges

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2022
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023
@elfosardo
Copy link
Contributor Author

/retest

1 similar comment
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

@deads2k hi! Please have a look at this when you get a chance, thanks!

@elfosardo
Copy link
Contributor Author

/cc @dtantsur

@openshift-ci openshift-ci bot requested a review from dtantsur February 8, 2023 09:16
@elfosardo
Copy link
Contributor Author

/retest

2 similar comments
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/cc @sadasu @bparees

@elfosardo
Copy link
Contributor Author

/cc @derekhiggins @honza @iurygregory

@elfosardo
Copy link
Contributor Author

this is similar to #27569
tests look ok, failures do not depend from this change

@bparees
Copy link
Contributor

bparees commented Feb 10, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@bparees bparees mentioned this pull request Feb 10, 2023
Merged
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Allow baremetal tests to run on Azure platform
978b05f 
Metal3 pods can now be deployed on Azure platform.
Baremetal hosts can be booted only via virtual media.
We only check for the presence of the metal3 pod to verify the
baremetal deployment is available in Azure too.
@elfosardo
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 978b05f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-azure-ovn-etcd-scaling 978b05f link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tdomnesc
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, elfosardo, tdomnesc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7f660fc into openshift:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

@dtantsur dtantsur Awaiting requested review from dtantsur

@bparees bparees Awaiting requested review from bparees

@sadasu sadasu Awaiting requested review from sadasu

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@honza honza Awaiting requested review from honza

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees

@tdomnesc tdomnesc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfosardo @bparees @tdomnesc @openshift-merge-robot