Take care of manifest config blob #10805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2016 20:02
Make sure to match image having config name equal to the wanted blob digest. Remember the image and allow access to its layers. Signed-off-by: Michal Minář <miminar@redhat.com>
Manifest configs are fetched using Get() method from blob store. Pullthrough middleware needs to override it as well to allow for pulling manifest v2 schema 2 images from remote repositories. Signed-off-by: Michal Minář <miminar@redhat.com>
mfojtik
added
the
approved
| os::cmd::expect_success "oc login -u schema2-user -p pass" | ||
| os::cmd::expect_success "oc project schema2" | ||
| # tagging remote docker.io/busybox image | ||
| os::cmd::expect_success "oc tag --source=docker busybox '${DOCKER_REGISTRY}/schema2/busybox'" |
There was a problem hiding this comment.
actually, I was wrong... I think this was supposed to be docker tag, but without the --source
There was a problem hiding this comment.
it's trying to tag and push using pure docker API calls
added 2 commits
September 5, 2016 20:13
Signed-off-by: Michal Minář <miminar@redhat.com>
Signed-off-by: Michal Minář <miminar@redhat.com>
mfojtik
force-pushed
the
take-care-of-manifest-config
branch
from
1c66f73
to
c442bf4
Compare
|
[merge] |
|
@mfojtik thanks! You were faster 😄 |
|
[test] |
|
Evaluated for origin test up to c442bf4 |
|
[merge] |
|
Evaluated for origin merge up to c442bf4 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8715/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8716/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone of: #10759
Resolves #10730
Manifest V2 schema 2 introduces a special blob called config which used to be emeedded in earlier schema. See upstream's spec for details. The config is stored as a regular blob on registry's storage. Thus the config needs to be treated similar to a regular layer:
The PR addresses the first 3 items. I'd like to cover the pruning case in a follow-up.