suggest exposable resources oc expose #10843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I think it's still valid to print the accepted extensions. E.g. |
juanvallejo
force-pushed
the
jvallejo_suggest-exposable-resources-oc-expose
branch
from
bda0645
to
3bba62b
Compare
Done! |
|
[test] |
openshift-bot
added
the
needs-rebase
Related Trello Card: https://trello.com/c/04lpfTQR/451-8-cli-improved-flows-and-ux-in-the-cli-evg-ux-p3 This patch updates `oc expose` output (with no resources provided) to a `kcmdutil.UsageError` so that a suggestion to use `oc expose -h` is displayed.
juanvallejo
force-pushed
the
jvallejo_suggest-exposable-resources-oc-expose
branch
from
3bba62b
to
095dc9c
Compare
openshift-bot
removed
the
needs-rebase
|
conformance test flaked on #9548 re[test] |
|
[merge] |
|
conformance test flaked on #9548 re[test] |
|
conformance test flaked on #9548 re[test] |
|
Evaluated for origin test up to 095dc9c |
|
re[merge] |
|
Evaluated for origin merge up to 095dc9c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9302/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9318/) (Image: devenv-rhel7_5079) |
juanvallejo
deleted the
jvallejo_suggest-exposable-resources-oc-expose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Trello Card:
https://trello.com/c/04lpfTQR/451-8-cli-improved-flows-and-ux-in-the-cli-evg-ux-p3
This patch updates
oc exposeoutput (with no resources provided)to a
kcmdutil.UsageErrorso that a suggestion to useoc expose -his displayed.
Before
$ oc exposeAfter
cc @openshift/cli-review