Change pipeline sample to use Node.js+MongoDB sample #11476
Conversation
|
there's really no point. even if we use the nodejs slave, we're not actually executing any build operations on the slave or leveraging any platform specifics from the slave. The build operations happen in openshift (we just trigger a ruby/nodejs/whatever buildconfig in openshift). so with that in mind do you still want the example updated? |
|
Understand on the slave point, was just trying to align the pipeline sample with slaves we have. A common source of confusion I've seen where people see the Ruby sample, the preference is node or java. This PR was to help with that confusion and give a better starting example. |
| "port": 5432, | ||
| "targetPort": 8080, | ||
| "nodePort": 0 | ||
|
|
There was a problem hiding this comment.
delete the extra newline
…" Jenkins slave. fixed space and service dependency annotation
|
Push deleted line and also noticed an error in the service grouping annotation and yes I tested it! |
|
did you regen the bootstrap content? travis isn't happy |
|
I did regen it. I just regen'd locally and git doesn't see a difference. Will continue to investigate. |
|
[merge] we'll see what the merge queue says. |
|
Evaluated for origin merge up to a68d9ae |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to a68d9ae |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10427/) (Base Commit: 2dccff1) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10475/) (Base Commit: d4771f5) (Image: devenv-rhel7_5227) |
| @@ -43,463 +43,455 @@ | |||
| "strategy": { | |||
| "type": "JenkinsPipeline", | |||
| "jenkinsPipelineStrategy": { | |||
| "jenkinsfile": "node('maven') {\nstage 'build'\nopenshiftBuild(buildConfig: 'ruby-sample-build', showBuildLogs: 'true')\nstage 'deploy'\nopenshiftDeploy(deploymentConfig: 'frontend')\n}" | |||
| "jenkinsfile": "node('nodejs') {\nstage 'build'\nopenshiftBuild(buildConfig: '${NAME}' showBuildLogs: 'true')\nstage 'deploy'\nopenshiftDeploy(deploymentConfig: '${NAME}')\n}" | |||
There was a problem hiding this comment.
should add a comma before 'showBuildLogs'
There was a problem hiding this comment.
thanks @dongboyan77
@sspeiche you said you tested this....
There was a problem hiding this comment.
@bparees I guess not enough, I did deploy the template but I guess I was impatient to wait for Jenkins to run (walks away hanging head in shame)
Since we don't have a ruby slave, we should leverage the nodejs slave we have