update missing probe severity to info #11968

juanvallejo · 2016-11-18T17:42:55Z

This patch changes the marker severity of missing probes (liveness and readiness) from osgraph.WarningSeverity to osgraph.InfoSeverity. It also adds a linebreak between Errors, Warnings, and Infos.

Example

$ oc status -v
In project default on server https://10.13.137.149:8443

http://www.pictre.org (svc/frontend)

https://idling-echo-reencrypt-default.router.default.svc.cluster.local (reencrypt) (svc/idling-echo)
http://idling-echo-default.router.default.svc.cluster.local
  dc/idling-echo deploys docker.io/openshift/node:latest
    deployment #1 deployed 2 days ago - 3 pods

svc/kubernetes - 172.30.0.1 ports 443, 53->8053, 53->8053

dc/test-deployment-config deploys docker.io/openshift/origin-pod:latest
  deployment #1 deployed 2 days ago - 1 pod

bc/test-buildconfig source builds git://github.com/openshift/ruby-hello-world.git on docker.io/centos/ruby-22-centos7:latest
  not built yet

Errors:
  * route/foo is routing traffic to svc/foo, but either the administrator has not installed a router or the router is not selecting this route.
    try: oc adm router -h
  * route/idling-echo is routing traffic to svc/idling-echo, but either the administrator has not installed a router or the router is not selecting this route.
    try: oc adm router -h
  * route/idling-echo-reencrypt is routing traffic to svc/idling-echo, but either the administrator has not installed a router or the router is not selecting this route.
    try: oc adm router -h
  * route/my-route is routing traffic to svc/frontend, but either the administrator has not installed a router or the router is not selecting this route.
    try: oc adm router -h

Warnings:
  * route/foo is supposed to route traffic to svc/foo but svc/foo doesn't exist.
  * route/idling-echo doesn't have a port specified and is routing traffic to svc/idling-echo which uses multiple ports.
  * route/idling-echo-reencrypt doesn't have a port specified and is routing traffic to svc/idling-echo which uses multiple ports.

Infos:
  * dc/idling-echo has no readiness probe to verify pods are ready to accept traffic or ensure deployment is successful.
    try: oc set probe dc/idling-echo --readiness ...
  * dc/idling-echo has no liveness probe to verify pods are still running.
    try: oc set probe dc/idling-echo --liveness ...
  * dc/test-deployment-config has no readiness probe to verify pods are ready to accept traffic or ensure deployment is successful.
    try: oc set probe dc/test-deployment-config --readiness ...
  * dc/test-deployment-config has no liveness probe to verify pods are still running.
    try: oc set probe dc/test-deployment-config --liveness ...

View details with 'oc describe <resource>/<name>' or list everything with 'oc get all'.

cc @jwforres @deads2k @fabianofranz

juanvallejo · 2016-11-18T17:45:36Z

[test]

jwforres · 2016-11-18T17:59:42Z

I would use "Info:" for the header not "Infos:" you wouldn't say
Informations, you would say Information

On Fri, Nov 18, 2016 at 12:42 PM, Juan Vallejo notifications@github.com
wrote:

Fixes #10294 #10294

This patch changes the marker severity of missing probes (liveness and
readiness) from osgraph.WarningSeverity to osgraph.InfoSeverity. It also
adds a linebreak between Errors, Warnings, and Infos.

Example

$ oc status -v
In project default on server https://10.13.137.149:8443
http://www.pictre.org (svc/frontend)
https://idling-echo-reencrypt-default.router.default.svc.cluster.local (reencrypt) (svc/idling-echo)http://idling-echo-default.router.default.svc.cluster.local
dc/idling-echo deploys docker.io/openshift/node:latest
deployment #1 deployed 2 days ago - 3 pods

svc/kubernetes - 172.30.0.1 ports 443, 53->8053, 53->8053

dc/test-deployment-config deploys docker.io/openshift/origin-pod:latest
deployment #1 deployed 2 days ago - 1 pod

bc/test-buildconfig source builds git://github.com/openshift/ruby-hello-world.git on docker.io/centos/ruby-22-centos7:latest
not built yet

Errors:

route/foo is routing traffic to svc/foo, but either the administrator has not installed a router or the router is not selecting this route.
try: oc adm router -h

route/idling-echo is routing traffic to svc/idling-echo, but either the administrator has not installed a router or the router is not selecting this route.
try: oc adm router -h

route/idling-echo-reencrypt is routing traffic to svc/idling-echo, but either the administrator has not installed a router or the router is not selecting this route.
try: oc adm router -h

route/my-route is routing traffic to svc/frontend, but either the administrator has not installed a router or the router is not selecting this route.
try: oc adm router -h

Warnings:

route/foo is supposed to route traffic to svc/foo but svc/foo doesn't exist.

route/idling-echo doesn't have a port specified and is routing traffic to svc/idling-echo which uses multiple ports.

route/idling-echo-reencrypt doesn't have a port specified and is routing traffic to svc/idling-echo which uses multiple ports.

Infos:

dc/idling-echo has no readiness probe to verify pods are ready to accept traffic or ensure deployment is successful.
try: oc set probe dc/idling-echo --readiness ...

dc/idling-echo has no liveness probe to verify pods are still running.
try: oc set probe dc/idling-echo --liveness ...

dc/test-deployment-config has no readiness probe to verify pods are ready to accept traffic or ensure deployment is successful.
try: oc set probe dc/test-deployment-config --readiness ...

dc/test-deployment-config has no liveness probe to verify pods are still running.
try: oc set probe dc/test-deployment-config --liveness ...

View details with 'oc describe /' or list everything with 'oc get all'.

cc @jwforres https://github.com/jwforres @deads2k
https://github.com/deads2k @fabianofranz

https://github.com/fabianofranz

You can view, comment on, or merge this pull request online at:

#11968
Commit Summary

update missing probe severity to info

File Changes

M pkg/api/kubegraph/analysis/podspec.go
https://github.com/openshift/origin/pull/11968/files#diff-0 (2)

M pkg/cmd/cli/describe/projectstatus.go
https://github.com/openshift/origin/pull/11968/files#diff-1 (29)

M pkg/deploy/graph/analysis/dc.go
https://github.com/openshift/origin/pull/11968/files#diff-2 (2)

Patch Links:

https://github.com/openshift/origin/pull/11968.patch

https://github.com/openshift/origin/pull/11968.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11968, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZk7cWR5QexfCdPXb1HNiytBlSB7l0-ks5q_eOjgaJpZM4K2viZ
.

juanvallejo · 2016-11-18T18:05:23Z

@jwforres

I would use "Info:" for the header not "Infos:" you wouldn't say
Informations, you would say Information

Done! Do you think Notices or something along those lines would sound better instead of Info?

jwforres · 2016-11-18T18:08:09Z

Hmm that would probably be OK too, I don't have a strong opinion either way.

On Fri, Nov 18, 2016 at 1:05 PM, Juan Vallejo notifications@github.com
wrote:

@jwforres https://github.com/jwforres

I would use "Info:" for the header not "Infos:" you wouldn't say
Informations, you would say Information

Done! Do you think Notices or something along those lines would sound
better instead of Info?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11968 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZk7T1Pev_1-pjLOEs0bXTk4jYBQy-3ks5q_ejngaJpZM4K2viZ
.

fabianofranz · 2016-11-18T18:22:38Z

pkg/cmd/cli/describe/projectstatus.go

@@ -304,6 +304,10 @@ func (d *ProjectStatusDescriber) Describe(namespace, name string) (string, error
 		warningMarkers := allMarkers.BySeverity(osgraph.WarningSeverity)
 		if len(warningMarkers) > 0 {
 			if d.Suggest {
+				// add linebreak between Errors list and Warnings list
+				if len(errorMarkers) > 0 {
+					fmt.Fprintln(out, "")


nit, fmt.Fprintln(out)

fabianofranz · 2016-11-18T18:23:03Z

pkg/cmd/cli/describe/projectstatus.go

+			if d.Suggest {
+				// add linebreak between Warnings list and Info List
+				if len(warningMarkers) > 0 || len(warningMarkers) > 0 {
+					fmt.Fprintln(out, "")


fabianofranz · 2016-11-18T18:23:33Z

LGTM, no strong opinion about the wording. Let me know when this is good to go.

juanvallejo · 2016-11-18T18:44:23Z

@fabianofranz thanks for the review, almost good to go, added a printMarkerSuggestions function to avoid duplicating code for Errors, Warnings, and Info

juanvallejo · 2016-11-18T21:06:31Z

integration check flaked on #9203 re[test]

fabianofranz · 2016-11-18T21:27:30Z

pkg/cmd/cli/describe/projectstatus.go

+		if len(infoMarkers) > 0 {
+			if d.Suggest {
+				// add linebreak between Warnings list and Info List
+				if len(warningMarkers) > 0 || len(warningMarkers) > 0 {


Double-check just in case. :)

:) Thanks for catching that

fabianofranz · 2016-11-18T21:43:12Z

LGTM [merge]

openshift-bot · 2016-11-18T21:45:37Z

Evaluated for origin merge up to 2ce9162

openshift-bot · 2016-11-18T22:37:37Z

Evaluated for origin test up to 2ce9162

openshift-bot · 2016-11-18T22:37:46Z

continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11572/) (Base Commit: f056a5b)

openshift-bot · 2016-11-18T23:13:21Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11573/) (Base Commit: 271fff8) (Image: devenv-rhel7_5387)

openshift-bot · 2016-11-18T23:59:54Z

continuous-integration/openshift-jenkins/test SUCCESS

juanvallejo force-pushed the jvallejo/update-missing-probe-severity-to-info branch from 9cdb35a to 3b232f2 Compare November 18, 2016 17:44

juanvallejo force-pushed the jvallejo/update-missing-probe-severity-to-info branch from 3b232f2 to 6378793 Compare November 18, 2016 18:04

fabianofranz reviewed Nov 18, 2016

View reviewed changes

update missing probe severity to info

55bae56

juanvallejo force-pushed the jvallejo/update-missing-probe-severity-to-info branch from 6378793 to 55bae56 Compare November 18, 2016 18:25

juanvallejo force-pushed the jvallejo/update-missing-probe-severity-to-info branch from 0592719 to 106c43d Compare November 18, 2016 18:47

fabianofranz reviewed Nov 18, 2016

View reviewed changes

create printMarkerSuggestions func

2ce9162

juanvallejo force-pushed the jvallejo/update-missing-probe-severity-to-info branch from 106c43d to 2ce9162 Compare November 18, 2016 21:34

openshift-bot merged commit 3b2bbe5 into openshift:master Nov 19, 2016

juanvallejo deleted the jvallejo/update-missing-probe-severity-to-info branch November 21, 2016 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update missing probe severity to info #11968

update missing probe severity to info #11968

juanvallejo commented Nov 18, 2016

juanvallejo commented Nov 18, 2016

jwforres commented Nov 18, 2016

https://github.com/fabianofranz

juanvallejo commented Nov 18, 2016

jwforres commented Nov 18, 2016

fabianofranz Nov 18, 2016

fabianofranz Nov 18, 2016

fabianofranz commented Nov 18, 2016

juanvallejo commented Nov 18, 2016

juanvallejo commented Nov 18, 2016

fabianofranz Nov 18, 2016

juanvallejo Nov 18, 2016

fabianofranz commented Nov 18, 2016

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016 •

edited

openshift-bot commented Nov 18, 2016

update missing probe severity to info #11968

update missing probe severity to info #11968

Conversation

juanvallejo commented Nov 18, 2016

juanvallejo commented Nov 18, 2016

jwforres commented Nov 18, 2016

https://github.com/fabianofranz

juanvallejo commented Nov 18, 2016

jwforres commented Nov 18, 2016

fabianofranz Nov 18, 2016

Choose a reason for hiding this comment

fabianofranz Nov 18, 2016

Choose a reason for hiding this comment

fabianofranz commented Nov 18, 2016

juanvallejo commented Nov 18, 2016

juanvallejo commented Nov 18, 2016

fabianofranz Nov 18, 2016

Choose a reason for hiding this comment

juanvallejo Nov 18, 2016

Choose a reason for hiding this comment

fabianofranz commented Nov 18, 2016

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016 • edited

openshift-bot commented Nov 18, 2016

openshift-bot commented Nov 18, 2016 •

edited