Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-app: fix priority of Jenkinsfile, Dockerfile, source when strategy unspecified #11982

Merged

Conversation

jim-minter
Copy link
Contributor

https://trello.com/c/H6ZwrpCo/995-5-new-app-new-build-support-for-pipeline-buildconfigs-techdebt

@wanghaoran1988

Resolves the further discussion in #11897.

I agree it's not clear what's best and no way to maintain true compatibility.

jenkinsfile -> dockerfile -> source seems reasonable to me. As you say, making jenkinsfile king makes sense.

@bparees
Copy link
Contributor

bparees commented Nov 21, 2016

lgtm [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9c2cb79

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11609/) (Base Commit: 1f1e6de)

@bparees
Copy link
Contributor

bparees commented Nov 22, 2016

[merge]

Ben Parees | OpenShift

On Nov 21, 2016 8:37 PM, "OpenShift Bot" notifications@github.com wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11621/) (Base
Commit: 75aa09c
75aa09c
)


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#11982 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3ngjJRHFasrpbwJnThoJgrmBSE5qks5rAkdRgaJpZM4K4ZtN
.

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9c2cb79

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11622/) (Base Commit: 75aa09c) (Image: devenv-rhel7_5397)

@openshift-bot openshift-bot merged commit bdccd7d into openshift:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants