Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that SDN API object CIDRs are in canonical form #13508

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Validate that SDN API object CIDRs are in canonical form #13508

merged 2 commits into from
Apr 7, 2017

Commits on Apr 7, 2017

  1. Warn at master startup if cluster/service CIDR is mis-specified 

    Previously you could say things like

  clusterNetworkCIDR: "10.128.32.99/14"

and the "extra" bits in the address would just be ignored and that
would count as "10.128.0.0/14". Make it warn about this now (but still
accept it).
    @danwinship
    danwinship committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    3a10959 View commit details
    Browse the repository at this point in the history

  2. Validate that SDN API object CIDRs are in canonical form 

    Eg, if you want ClusterNetwork to be "10.128.0.0/14", you have to say
"10.128.0.0/14", not "10.128.0.1/14" or "10.128.32.99/14".

All OpenShift-generated objects already did this correctly, but this
might cause previously-considered-valid EgressNetworkPolicy objects to
start failing to validate.
    @danwinship
    danwinship committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    a0822dd View commit details
    Browse the repository at this point in the history