Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set layer size whether it found in cache or not #14166

Merged
merged 1 commit into from May 25, 2017
Merged

Set layer size whether it found in cache or not #14166

merged 1 commit into from May 25, 2017

Conversation

dmage
Copy link
Member

@dmage dmage commented May 12, 2017

@dmage
Set layer size whether it found in cache or not
5e2c3f3 
Fixes bug 1442855

Signed-off-by: Oleg Bulatov <obulatov@redhat.com>
@dmage dmage requested review from miminar and legionus May 12, 2017 13:40
@dmage
Copy link
Member Author

dmage commented May 12, 2017

[test]

legionus
legionus approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@legionus legionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmage
Copy link
Member Author

dmage commented May 15, 2017

Flake #14187, re[test].

miminar
miminar approved these changes May 15, 2017
View reviewed changes
Copy link

@miminar miminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Unit test would be nice.

@dmage
Copy link
Member Author

dmage commented May 15, 2017

Flake #14041, re[test].

@dmage
Copy link
Member Author

dmage commented May 15, 2017

Flake #13945, re[test].

@dmage
Copy link
Member Author

dmage commented May 15, 2017

Flake #13966, re[test].

@dmage
Copy link
Member Author

dmage commented May 15, 2017

Flake #13943, re[test].

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 5e2c3f3

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1469/) (Base Commit: 1e35d49)

@legionus
Copy link
Contributor

[merge]

1 similar comment
@legionus
Copy link
Contributor

[merge]

@mfojtik
Copy link
Member

mfojtik commented May 25, 2017

[merge][severity: blocker]

https://bugzilla.redhat.com/show_bug.cgi?id=1442855

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 5e2c3f3

@openshift-bot
Copy link
Contributor

openshift-bot commented May 25, 2017 •
edited

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/790/) (Base Commit: 0bea328) (Extended Tests: blocker) (Image: devenv-rhel7_6269)

@openshift-bot openshift-bot merged commit 828590c into openshift:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar miminar approved these changes

@legionus legionus legionus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmage @openshift-bot @legionus @mfojtik @miminar