Reinstate "e2e test: remove PodCheckDns flake" #14366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sosiouxme reverting was the only thing I could come up back then. I'm perfectly fine with merging this in and you can work on the flake on its own. |
|
LGTM |
|
Thanks, I'll merge this next week when the queue opens (this isn't a blocker). |
This reverts commit 51ec303.
sosiouxme
force-pushed
the
20170525-reinstate-flake-fix
branch
from
7979e0b
to
1c8b86e
Compare
|
Evaluated for origin merge up to 1c8b86e |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 1c8b86e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1948/) (Base Commit: 361661e) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/938/) (Base Commit: 1565480) (Image: devenv-rhel7_6333) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reinstates a workaround for test flake #9888
@soltysh I was on leave and couldn't review #12890 or my feedback would have been... how does this change the testing timing? It's just a change to what text it's expecting in order to fail/pass the test. I don't see how it would address the problem. Meanwhile the flake came back when this was reverted. What do you think, is there something I'm missing?