Update image local build script #14599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are writing the `FROM` statement for the local image build Dockerfile, we need to use the fully qualified name of the image we are building on top of. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
When the script fails to build an image, we need to ensure that the temp directory we created for context is cleaned up anyway. Trapping the functionality on exit is the appropriate way to acheive this. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
changed the title
bparees
reviewed
Jun 12, 2017
| @@ -161,5 +165,3 @@ def debug(message): | |||
|
|
|||
| remove(join(context_dir, "Dockerfile")) | |||
| rmtree(join(context_dir, "src", image)) | |||
|
|
|||
| rmtree(context_dir) | |||
There was a problem hiding this comment.
why don't we want this cleanup?
|
(more manually merging because it can't break anything and don't want to block others on the queue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the full image name for local image build FROM
When we are writing the
FROMstatement for the local image buildDockerfile, we need to use the fully qualified name of the image we
are building on top of.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Ensure local image tmp dirs are cleaned up on error
When the script fails to build an image, we need to ensure that the temp
directory we created for context is cleaned up anyway. Trapping the
functionality on exit is the appropriate way to acheive this.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Removed extraneous comma from local build debugging output
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/cc @bparees
@knobunc can you try this one out?