Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case for mixed/uppercase host name #14858

Closed
wants to merge 1 commit into from
Closed

Test case for mixed/uppercase host name #14858

wants to merge 1 commit into from

Conversation

pecameron
Copy link
Contributor

@pecameron pecameron commented Jun 23, 2017 •
edited

This is a test case for PR 14157

When a user provides a mixed or uppercase host name the router converts
it to lower case before matching it to existing routes.

Test for:
#14157

bug 1461466
https://bugzilla.redhat.com/show_bug.cgi?id=1461466

Test case:
bug 1467006
https://bugzilla.redhat.com/show_bug.cgi?id=1467006

@pecameron
Copy link
Contributor Author

pecameron commented Jun 23, 2017 •
edited by eparis

@knobunc PTAL
This must go in after #14157

@knobunc knobunc changed the title Test case for mixed/uppercase host name Test case for mixed/uppercase host name [DO NOT MERGE] Jun 23, 2017
@knobunc
Copy link
Contributor

knobunc commented Jun 23, 2017

@openshift/networking PTAL

knobunc
knobunc requested changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need two different routes. One for /Letter and the other for /letter

Then hit them and make sure they are different.

@eparis
Copy link
Member

eparis commented Jul 1, 2017

[test]

@eparis
Copy link
Member

eparis commented Jul 1, 2017

[testextended][extended:core(router)]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 32ac928

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2905/) (Base Commit: 4917a3e) (PR Branch Commit: 32ac928)

@openshift-merge-robot openshift-merge-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2017
@knobunc knobunc changed the title Test case for mixed/uppercase host name [DO NOT MERGE] Test case for mixed/uppercase host name Jul 24, 2017
@knobunc
Copy link
Contributor

knobunc commented Jul 24, 2017

[testextended][extended:core(router)]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 32ac928

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/911/) (Base Commit: 4917a3e) (PR Branch Commit: 32ac928) (Extended Tests: core(router))

@pecameron
Copy link
Contributor Author

/assign @knobunc

@pecameron
Copy link
Contributor Author

/approve no-issue

@pecameron
Copy link
Contributor Author

/assign @mfojtik

@knobunc
Copy link
Contributor

knobunc commented Jul 26, 2017

@pecameron can we add a /letter test case to make sure that the paths are not mashed together by the case comparison.

@pecameron
Copy link
Contributor Author

@knobunc the case comparison smashes the host to lower and then does the test. /Letter is passed as is. If the shift to lower went too far we would get /letter which is broken. What are you looking for in the /letter case? Adding it is a little complex. Also it restarts the approval process. You are not an approver in test/extended/OWNERS.

@pecameron
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
knobunc
knobunc approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to go in if we can get the tests to pass. We can add the other test later.

@knobunc
Copy link
Contributor

knobunc commented Jul 31, 2017

/approve no-issue

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pecameron

Associated issue requirement bypassed by: knobunc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2017
@stevekuznetsov
Copy link
Contributor

/unassign

@pecameron pecameron force-pushed the bz1461466t branch 2 times, most recently from 57aa2df to 86be7ca Compare August 1, 2017 17:58
@pecameron
Copy link
Contributor Author

/retest

1 similar comment
@eparis
Copy link
Member

eparis commented Aug 1, 2017

/retest

@pecameron
Test case for mixed/uppercase host name
9393b7e 
This is a test case for PR 14157

When a  user provides a mixed or uppercase host name the router converts
it to lower case before matching it to existing routes.

Test for:
openshift#14157

bug 1461466
https://bugzilla.redhat.com/show_bug.cgi?id=1461466
@openshift-merge-robot openshift-merge-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2017
@pecameron
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor

/test extended_conformance_install_update

2 similar comments
@stevekuznetsov
Copy link
Contributor

/test extended_conformance_install_update

@stevekuznetsov
Copy link
Contributor

/test extended_conformance_install_update

@pecameron
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

@pecameron PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2017
@stevekuznetsov
Copy link
Contributor

this had a bad target branch

@pecameron
Copy link
Contributor Author

@stevekuznetsov Do you know what causes this? Where is the haprox-router image built? How do I find out why it failed to build/push? The changes in this PR are in test/extended.

github.com/openshift/origin/test/integration .TestRouter
router_test.go:75: Error starting container openshift/origin-haproxy-router : no such image

@stevekuznetsov
Copy link
Contributor

Unclear. I'd re-test on a new PR and see if it re-occurs

@pecameron
Copy link
Contributor Author

@stevekuznetsov OK I'll get a new PR going.

@openshift-ci-robot
Copy link

@pecameron: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end 9393b7e link /test end_to_end
ci/openshift-jenkins/integration 9393b7e link /test integration
ci/openshift-jenkins/extended_templates 9393b7e link /test extended_templates
ci/openshift-jenkins/extended_conformance_gce 9393b7e link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update 9393b7e link /test extended_conformance_install_update

Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

Assignees

@mfojtik mfojtik

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pecameron @knobunc @eparis @openshift-bot @openshift-merge-robot @stevekuznetsov @openshift-ci-robot @mfojtik