SWEET32 mitigation: Disable Triple-DES #15400
Conversation
|
@openshift/security |
openshift-merge-robot
added
the
size/XS
|
LGTM but I will defer to @liggitt for final review |
| tls.TLS_RSA_WITH_AES_128_CBC_SHA, // forbidden by http/2 | ||
| tls.TLS_RSA_WITH_AES_256_CBC_SHA, // forbidden by http/2 | ||
| tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA, // forbidden by http/2 | ||
| tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA, // forbidden by http/2 |
There was a problem hiding this comment.
I don't mind dropping these, but I'd like to leave commented out breadcrumbs explaining why we're not including things from the intermediate suite and why, e.g.
// tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA, // forbidden by http/2, disabled to mitigate SWEET32 attack
// tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA, // forbidden by http/2, disabled to mitigate SWEET32 attack
There was a problem hiding this comment.
That's a very good idea. I have updated my PR.
Triple-DES (3DES-CBC, DES-CBC3) should no longer be used. It's an old and slow block cipher with an effective key size of 112 bits. Since 3DES is build around DES, it has a block size of 64 bits. 64 bit block ciphers are vulnerable to a birthday attack known as SWEET32. Since Origin requires a minimum TLS version of 1.2, 3DES can be disabled safely. All relevant TLS 1.2 clients support AES. Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tiran Associated issue requirement bypassed by: liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 15434, 15382, 15018, 15314, 15400) |
Triple-DES (3DES-CBC, DES-CBC3) should no longer be used. It's an old
and slow block cipher with an effective key size of 112 bits. Since 3DES is
build around DES, it has a block size of 64 bits. 64 bit block ciphers
are vulnerable to a birthday attack known as SWEET32.
Since Origin requires a minimum TLS version of 1.2, 3DES can be disabled
safely. All relevant TLS 1.2 clients support AES.
Signed-off-by: Christian Heimes cheimes@redhat.com