GetBootstrapSecurityContextConstraints: change return type to a slice of pointers #15924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/S
|
Test flake #13966 |
openshift-merge-robot
added
the
needs-rebase
php-coder
force-pushed
the
scc_change_bootstrap_func_result
branch
from
8c849c0
to
a3cd039
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Test flake #15912 |
|
@mfojtik PTAL |
pweil-
approved these changes
Aug 25, 2017
|
Ping. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: php-coder, pweil- The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 15964, 15624, 15924) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #15923 (comment):
It turned out that in all the places we need
[]*SecurityContextConstraints. This PR updatesGetBootstrapSecurityContextConstraintsfunction to return this type. This change simplify our code.PTAL @pweil- @adelton
CC @simo5