Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit imports to dockerregistry #16251

Merged
merged 1 commit into from Sep 11, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 8, 2017

Limit the imports to pkg/dockerregistry to set up for splitting it out.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2017
@bparees
Copy link
Contributor

bparees commented Sep 8, 2017

/assign @legionus

@deads2k
Copy link
Contributor Author

deads2k commented Sep 8, 2017

#13966
/retest

@legionus
Copy link
Contributor

legionus commented Sep 9, 2017

@deads2k What about the github.com/openshift/origin/cmd/dockerregistry and github.com/openshift/origin/pkg/cmd/dockerregistry ? They are also part of registry server and should be splitted.

@legionus
Copy link
Contributor

legionus commented Sep 9, 2017

@deads2k
Copy link
Contributor Author

deads2k commented Sep 9, 2017

@deads2k I don't know what to do with https://github.com/openshift/origin/blob/master/cmd/dockerregistry/main.go#L20-L23 .

I'm leaning towards doing slightly crazy things and giving you a separate vendor folder, sans cobra. That would let us remove everything else.

@legionus
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2017
@legionus
Copy link
Contributor

/approve

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, legionus

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 6109bc9 into openshift:master Sep 11, 2017
@deads2k deads2k deleted the docker-01-ratchet branch January 24, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants