Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node, systemcontainer: initialize dnsmasq #16378

Merged

Conversation

giuseppe
Copy link
Member

This is already done for the version of node installed on the host.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1482239

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
sd notifications work well now in runc, so start using them.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2017
@sdodson
Copy link
Member

sdodson commented Sep 15, 2017

/approve

@sdodson
Copy link
Member

sdodson commented Sep 15, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, sdodson

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2017
@0xmichalis 0xmichalis removed their assignment Sep 15, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16384, 16327, 16199, 16286, 16378)

openshift-merge-robot added a commit that referenced this pull request Sep 16, 2017
Automatic merge from submit-queue (batch tested with PRs 16384, 16327, 16199, 16286, 16378)

node, systemcontainer: initialize dnsmasq

This is already done for the version of node installed on the host.
@openshift-merge-robot openshift-merge-robot merged commit 7bedfbb into openshift:master Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants