disallow empty static node names #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -338,10 +338,13 @@ func (args MasterArgs) BuildSerializeableKubeMasterConfig() (*configapi.Kubernet | |||
| masterIP = ip.String() | |||
| } | |||
|
|
|||
| staticNodeList := util.NewStringSet(args.NodeList...) | |||
There was a problem hiding this comment.
--nodes= resulting in [""] seems like a bug in util.StringList
|
nits, and I'd prefer an upstream fix in StringList, but LGETM (looks good enough to merge) |
deads2k
force-pushed
the
deads-disallow-empty-node-names
branch
from
163d384
to
5789426
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1587/) (Image: devenv-fedora_1286) |
|
Evaluated for origin up to 5789426 |
openshift-bot
pushed a commit
that referenced
this pull request
Apr 16, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1751.
@liggitt