add stack backtrace to util.FatalErr #17661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
bparees
reviewed
Dec 7, 2017
test/extended/util/cli.go
Outdated
| @@ -585,5 +586,7 @@ func (c *CLI) Execute() error { | |||
|
|
|||
| // FatalErr exits the test in case a fatal error has occurred. | |||
| func FatalErr(msg interface{}) { | |||
| // the path that leads to this being called isn't always clear... | |||
| fmt.Fprint(g.GinkgoWriter, string(debug.Stack())) | |||
jim-minter
force-pushed
the
issue17659
branch
from
6011e15
to
e4c9d29
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jim-minter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 17663, 17661, 17219). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debugging for #17659
@mfojtik @bparees