Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake in cluster resource quota test #19321

Merged
merged 1 commit into from Apr 11, 2018
Merged

Fix flake in cluster resource quota test #19321

merged 1 commit into from Apr 11, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 11, 2018

Fixes #19282

This resolves a long-standing race condition in the first test that was masked by an overly broad output regex that happened to match -o name output prior to the 1.10 rebase

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Apr 11, 2018

/assign @deads2k

@deads2k
Copy link
Contributor

deads2k commented Apr 11, 2018

Well, there is a cure for laziness it seems. Looks like a lot of trouble though, think I'll leave it for someone else... :)

/lgtm

green button this after it passes test-cmd

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Contributor Author

liggitt commented Apr 11, 2018

test/cmd succeeded, merging to unblock the queue

@liggitt liggitt merged commit 709739b into openshift:master Apr 11, 2018
@openshift-ci-robot
Copy link

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 0ba9d95 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt liggitt deleted the quota-flake branch April 13, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
3 participants