up: remove --env flag

[mfojtik]

This removes the --env flag from cluster up. It was passed just to kubelet and it can cause more harm than good to support it.

/cc @deads2k

[deads2k]

/lgtm

@mfojtik indicate a release-note that they can --write-config and update the static pod definition.

[deads2k]

/hold

It just occurred to me that the kubelet may be naughty.

@sjenning does the kubelet use env vars to control behavior? If so, we'll hide this instead.

[mfojtik]

/retest

[sjenning]

@sjenning does the kubelet use env vars to control behavior?

I don't know of any behavior that is controlled that way and a quick search for calls to os.Environ() turns up nothing

[deads2k]

/hold cancel

[mfojtik]

@deads2k merge?

[deads2k]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• contrib/completions/OWNERS [deads2k,mfojtik]
• pkg/oc/bootstrap/OWNERS [deads2k,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment