get build logs through the kube-apiserver, not the kubelet #19476
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
| @@ -340,38 +313,17 @@ func (r *REST) New() runtime.Object { | |||
| // pipeLogs retrieves the logs for a particular container and streams them into the provided writer. | |||
| func (r *REST) pipeLogs(ctx apirequest.Context, namespace, buildPodName string, containerLogOpts *kapi.PodLogOptions, writer io.Writer) error { | |||
| glog.V(4).Infof("pulling build pod logs for %s/%s, container %s", namespace, buildPodName, containerLogOpts.Container) | |||
| location, transport, err := pod.LogLocation(r.PodGetter, r.ConnectionInfo, ctx, buildPodName, containerLogOpts) | |||
There was a problem hiding this comment.
@bparees I didn't find any unit tests for this. That's not like you. Are they in another package? I made a mock for the easy path (which works), but not this path and nothing failed....
There was a problem hiding this comment.
a unit test for what specifically?
mostly the build logs flows are exercised by the extended build tests.
There was a problem hiding this comment.
a unit test for what specifically?
For the "stitch multiple log streams into a single log stream" flow.
There was a problem hiding this comment.
yeah i relied on our extended tests which are all highly dependent on build log output checking.
deads2k
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
got my answer about the tests. Removing wip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Go through the kube-apiserver instead of running direct to the kubelet for easier composition.