add --dry-run option to "oc adm groups new" #19811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
cd49de5
to
c3bfddc
Compare
|
/retest |
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
c3bfddc
to
5e69459
Compare
soltysh
approved these changes
May 24, 2018
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
enj
suggested changes
May 24, 2018
test/cmd/admin.sh
Outdated
| @@ -117,6 +117,11 @@ echo "certs: ok" | |||
| os::test::junit::declare_suite_end | |||
|
|
|||
| os::test::junit::declare_suite_start "cmd/admin/groups" | |||
| # test --dry-run flag for this command | |||
| os::cmd::expect_success_and_text 'oc adm groups new mygroup --dry-run' 'group "mygroup" created (dry run)' | |||
There was a problem hiding this comment.
Need to escape parentheses \(dry run\)
|
/retest Please review the full test history for this PR and help us cut down flakes. |
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
5e69459
to
706006c
Compare
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
2 times, most recently
from
764afbf
to
d1638d8
Compare
openshift-bot
added
the
needs-rebase
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
d1638d8
to
74306d1
Compare
openshift-bot
removed
the
needs-rebase
openshift-ci-robot
added
size/M
openshift-bot
added
the
needs-rebase
|
@juanvallejo do want to land this before we get there with our re-factors or we'll pick it up during those? |
I think we can land it now, will rebase |
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
74306d1
to
b7a249b
Compare
openshift-bot
removed
the
needs-rebase
|
@soltysh rebased |
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
b7a249b
to
04fcd4f
Compare
|
The error: test/integration/groups_test.go:193:10: cannot use func literal (type func("github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/runtime".Object, "io".Writer) error) as type printers.ResourcePrinter in field value:
func("github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/runtime".Object, "io".Writer) error does not implement printers.ResourcePrinter (missing PrintObj method)looks relevant. |
soltysh
approved these changes
Jul 4, 2018
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
04fcd4f
to
12ffdac
Compare
openshift-ci-robot
removed
lgtm
|
/retest |
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
12ffdac
to
9a716a4
Compare
openshift-ci-robot
added
size/L
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
7 times, most recently
from
f4a0f63
to
fdede35
Compare
|
/retest |
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
2 times, most recently
from
a670d96
to
5a4b961
Compare
openshift-bot
added
the
needs-rebase
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
5a4b961
to
fe6975d
Compare
openshift-bot
removed
the
needs-rebase
juanvallejo
force-pushed
the
jvallejo/add-dry-run-new-group
branch
from
fe6975d
to
f915be1
Compare
soltysh
approved these changes
Jul 27, 2018
| userapi "github.com/openshift/origin/pkg/user/apis/user" | ||
| userclientinternal "github.com/openshift/origin/pkg/user/generated/internalclientset" | ||
| usertypedclient "github.com/openshift/origin/pkg/user/generated/internalclientset/typed/user/internalversion" | ||
| userapiv1 "github.com/openshift/api/user/v1" |
There was a problem hiding this comment.
@juanvallejo yeah, we'll need to sweep them afterwards, I want to get these pulls in asap.
soltysh
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a --dry-run option to
oc adm groups newFixes #14807
cc @soltysh