Add an event poll for TestOAuthServiceAccountClientEvent #19824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrogers950
added
kind/test-flake
openshift-ci-robot
added
the
size/S
|
/test all |
|
Cherrypick #16850 here to check for failures. |
openshift-ci-robot
added
size/M
|
/test all |
2 similar comments
|
/test all |
|
/test all |
enj
reviewed
May 25, 2018
| err = wait.Poll(time.Second, 5*time.Second, func() (bool, error) { | ||
| evList, err = testServer.clusterAdminKubeClient.Core().Events(projectName).List(metav1.ListOptions{}) | ||
| if err != nil { | ||
| return false, nil |
There was a problem hiding this comment.
Pretty sure this should be return false, err. The List call should never error if I am reading this correctly.
mrogers950
force-pushed
the
sa-event-flake
branch
from
96861fa
to
fa7a943
Compare
|
/test all |
mrogers950
force-pushed
the
sa-event-flake
branch
from
fa7a943
to
5460a8e
Compare
openshift-ci-robot
added
size/S
|
/test all |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19821