add jenkins autoprovision extended tests #20319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
sig/developer-experience
size/M
bparees
reviewed
Jul 13, 2018
|
|
||
| // start the build | ||
| g.By("starting the pipeline build, including env var, and waiting for it to complete") | ||
| br, err := exutil.StartBuildAndWait(oc, "-e", "FOO2=BAR2", "sample-pipeline-withenvs") |
There was a problem hiding this comment.
we don't need to run anything, it should be sufficient to confirm the jenkins pod gets created. (don't even really need to wait for it to start up)
gabemontero
force-pushed
the
add-jenkins-autoprov-test
branch
from
4da6ec1
to
eb60205
Compare
bparees
reviewed
Jul 13, 2018
| exutil "github.com/openshift/origin/test/extended/util" | ||
| ) | ||
|
|
||
| var _ = g.Describe("[Feature:Builds] jenkins autoprovision", func() { |
There was a problem hiding this comment.
let's be brave and mark it conformance.
gabemontero
force-pushed
the
add-jenkins-autoprov-test
branch
from
eb60205
to
8107f64
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@openshift/sig-developer-experience fyi/ptal