Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore test for image signature workflow #20621

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

dmage
Copy link
Member

@dmage dmage commented Aug 13, 2018

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2018
@dmage
Copy link
Member Author

dmage commented Aug 14, 2018

/retest

@dmage
Copy link
Member Author

dmage commented Aug 15, 2018

/retest

3 similar comments
@dmage
Copy link
Member Author

dmage commented Aug 15, 2018

/retest

@dmage
Copy link
Member Author

dmage commented Aug 15, 2018

/retest

@dmage
Copy link
Member Author

dmage commented Aug 15, 2018

/retest

@dmage dmage force-pushed the test-image-signatures branch 7 times, most recently from 1a3e6da to efdabdd Compare August 21, 2018 14:43
@dmage
Copy link
Member Author

dmage commented Aug 21, 2018

/retest

@dmage
Copy link
Member Author

dmage commented Aug 22, 2018

/cc @bparees @mfojtik

This test is almost done except that the internal registry doesn't accept the token:

I0821 17:26:43.437071    5833 round_trippers.go:383] GET https://docker-registry.default.svc:5000/openshift/token?account=e2e-test-registry-signing-q8vj5-user&scope=repository%3Ae2e-test-registry-signing-q8vj5%2Fsigned%3Apull
I0821 17:26:43.437094    5833 round_trippers.go:390] Request Headers:
I0821 17:26:43.437108    5833 round_trippers.go:393]     Authorization: Basic ZTJlLXRlc3QtcmVnaXN0cnktc2lnbmluZy1xOHZqNS11c2VyOk9qWV9JZHp4VEtHZ0xrNFRoT0xuOVFBQUFBQUFBQUFB
I0821 17:26:43.445367    5833 round_trippers.go:408] Response Status: 401 Unauthorized in 8 milliseconds

Though, I don't know how to get logs from the registry to debug this issue.

@dmage
Copy link
Member Author

dmage commented Aug 22, 2018

I heard I shouldn't assume that the integrated registry is accessible directly from the test. And I need to start a pod to get something from the registry.

Can someone confirm this?

@dmage
Copy link
Member Author

dmage commented Aug 22, 2018

/retest

1 similar comment
@dmage
Copy link
Member Author

dmage commented Aug 22, 2018

/retest

@dmage
Copy link
Member Author

dmage commented Aug 22, 2018

@mfojtik confirmed today that I need to interact with the registry from a pod. As we want to test the oc util, I copy it into the pod from the host system.

@bparees bparees self-assigned this Aug 23, 2018
@bparees
Copy link
Contributor

bparees commented Aug 23, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018
@openshift-merge-robot openshift-merge-robot merged commit 8fa6f2f into openshift:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants