-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore test for image signature workflow #20621
Restore test for image signature workflow #20621
Conversation
9d41186
to
986553f
Compare
/retest |
f2d3e8d
to
7845827
Compare
/retest |
3 similar comments
/retest |
/retest |
/retest |
1a3e6da
to
efdabdd
Compare
/retest |
This test is almost done except that the internal registry doesn't accept the token:
Though, I don't know how to get logs from the registry to debug this issue. |
I heard I shouldn't assume that the integrated registry is accessible directly from the test. And I need to start a pod to get something from the registry. Can someone confirm this? |
efdabdd
to
7a75283
Compare
/retest |
1 similar comment
/retest |
@mfojtik confirmed today that I need to interact with the registry from a pod. As we want to test the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes openshift/image-registry#39.