New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite cluster-up to use rendering logic and bootkube start #21097

Merged

openshift-merge-robot merged 20 commits into openshift:master from mfojtik:feature-bootkube

Oct 2, 2018

Member

mfojtik commented Sep 25, 2018 •

edited

Changes in this PR are trying to re-assemble what the openshift 4.0 installer will do in order to bring the initial control plane up and running.

The way this will work is basically:

We generate the static pod manifests using the operator images that own the components (kube api server and controller manager) and the manifests for second stage that use daemonsets/configmaps/secrets.
We run bootkube start that will first move the static pod manifests into kubelet static pod manifest directory and wait until the initial control plane is up and running. Initial control plane use hostNetwork and hostPaths.
Once the initial control plane is running, bootkube will create the workload resources, secrets and config maps and wait until the second stage control plane is up and running
Once the daemonset based control plane is running, the bootkube will tear down the static pod control plane

At this point, the job of cluster up is done and users have working kubernetes control plane to add operators they will to run.

/cc @deads2k
/cc @sttts

openshift-ci-robot requested review from deads2k and sttts

September 25, 2018 13:29

openshift-ci-robot added the do-not-merge/work-in-progress label

openshift-bot added the needs-rebase label

openshift-ci-robot added approved size/XXL labels

mfojtik force-pushed the feature-bootkube branch from 6bd759d to f7b4ce5 Compare

September 26, 2018 07:20

openshift-bot removed the needs-rebase label

mfojtik force-pushed the feature-bootkube branch from f7b4ce5 to 8fbf845 Compare

September 26, 2018 07:34

mfojtik changed the title ~~WIP: refactor cluster up to use operators~~ WIP: Rewrite cluster-up to use rendering logic and bootkube start

mfojtik force-pushed the feature-bootkube branch 2 times, most recently from 7aa977b to afcded5 Compare

September 26, 2018 15:26

mfojtik changed the title ~~WIP: Rewrite cluster-up to use rendering logic and bootkube start~~ Rewrite cluster-up to use rendering logic and bootkube start

mfojtik removed the do-not-merge/work-in-progress label

mfojtik force-pushed the feature-bootkube branch 3 times, most recently from d022356 to 31629ad Compare

September 26, 2018 19:34

openshift-bot added the needs-rebase label

mfojtik force-pushed the feature-bootkube branch from 31629ad to 04df92d Compare

September 26, 2018 19:37

openshift-bot removed the needs-rebase label

Contributor

deads2k commented Sep 26, 2018

/lgtm

Worth another round of squashing I think to get under 10 commits. Feel free to squash mine. Don't forget a note and the world's best bash one liner :).

openshift-ci-robot assigned deads2k

openshift-ci-robot added the lgtm label

openshift-ci-robot commented Sep 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Sep 26, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Sep 26, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 27, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 27, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 27, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 27, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

sttts and others added 20 commits

October 1, 2018 22:16


          cluster-up: use bootkube to bootstrap the kube control plane

958a609


          cluster-up: create <base-dir>/render-tls dir and use for kube-apiserv…

8a90df4

…er secrets


          cluster-up: call cluster-kube-apiserver-operator render

747bff0


          cluster-up: remove transitional secret+configmap creation, now throug…

db8086e

…h bootkube phase 1


          cluster-up: switch etcd to static pod

14e48e2


          cluster-up: add assets rendering

8ddb445


          cluster-up: add sane api to track required images

9696def


          cluster-up: skim more from legacy cluster up

fa6cbbe


          cluster-up: pass hyperkube image to kube-apiserver render

9cb0ff9


          cluster-up: create assets/auth/kubeconfig

7b04b5d


          cluster-up: fix kubeconfig rendering of certs+keys

ff4c649


          cluster-up: tell kube-apiserver operator about secrets path

b1b4b65


          cluster-up: fix etcd certs+keys

8c84b03


          cluster-up: fix controller manager overrides

1437c19


          remove unnecessary oc cluster up bits

b081699


          fix import restrictions

316113f


          update completions

42d1dcd


          extended: pull and re-tag operator images

419d4b2


          cluster-up: move lock host path to base dir

e218396


          cluster-up: remove some default tests

4ec7ad2

mfojtik force-pushed the feature-bootkube branch from 0960b8c to 4ec7ad2 Compare

October 1, 2018 20:19

openshift-ci-robot commented Oct 1, 2018

New changes are detected. LGTM label has been removed.

openshift-ci-robot removed the lgtm label

Member Author

mfojtik commented Oct 1, 2018

/retest

openshift-ci-robot commented Oct 1, 2018 •

edited

@mfojtik: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_image_ecosystem	`31629ad`	link	`/test extended_image_ecosystem`
ci/openshift-jenkins/extended_builds	`31629ad`	link	`/test extended_builds`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Member Author

mfojtik commented Oct 2, 2018

/retest

mfojtik added the lgtm label

Member Author

mfojtik commented Oct 2, 2018

Reapplying the label as the last commits were just fixing the CI.

openshift-merge-robot merged commit 2f9d790 into openshift:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment