gate image ecosystem on samples operator conventions (including scan … #21947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
bparees
reviewed
Feb 1, 2019
bparees
reviewed
Feb 1, 2019
gabemontero
force-pushed
the
image-eco-too-eager
branch
from
f045f03
to
f2c1d6c
Compare
|
update pushed @bparees |
|
/approve i'm ok w/ whatever you decide to do, if it's passing the test at the end of the day. feel free to self-lgtm within reason. |
bparees
added
the
approved
|
given what we've learned about the install flow today, i suspect even 2.5 minutes may not be enough time for the imagestreams to get created+imported in some cases, but it's a good starting point. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for import errors)
see openshift/cluster-samples-operator#81 (comment)
the installer gating by operator availability is also being pursued, but these changes are better regardless of that outcome
/assign @bparees