Remove the rest of the pre-CRD network API support #21964
Conversation
openshift-ci-robot
added
the
size/XXL
danwinship
force-pushed
the
drop-old-network-api
branch
2 times, most recently
from
a919e17
to
28368e4
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
openshift-ci-robot
added
the
needs-rebase
danwinship
force-pushed
the
drop-old-network-api
branch
from
28368e4
to
e721893
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/retest |
danwinship
force-pushed
the
drop-old-network-api
branch
from
e721893
to
2c0d5fd
Compare
|
/retest |
1 similar comment
|
/retest |
This was left in to keep the SDN integration tests running, but then they broke because of something else and were removed anyway.
danwinship
force-pushed
the
drop-old-network-api
branch
from
2c0d5fd
to
9e94366
Compare
danwinship
force-pushed
the
drop-old-network-api
branch
from
9e94366
to
c6c5fa4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
This should be a no-op;
pkg/network/apiserverwas previously still used in the cmd and integration tests, but is not any longer. The internal/unversioned network types inpkg/network/apisstill existed, but nothing should have been using them (since CRD types do not have internal/unversioned equivalents).