Label vendor updates #22427
Label vendor updates #22427
Conversation
openshift-ci-robot
added
sig/master
size/M
|
/retest |
|
@deads2k I think that's useful, ptal |
|
the idea has merit. block on glide.lock updates too. I can read the intent, but I don't know enough to know if it works. /assign @stevekuznetsov |
|
/retest |
|
How about we try it and revert if it goes south? (We still have manual perms or forcing labels.) |
|
So I went to try it here: tnozicka/openshift-acme#91, approvers work, labeling didn't kick in. |
|
Actually it did kick in now tnozicka/openshift-acme#92 (comment). I was missing the label. Had to force push which unfortunately means it won't label the old PRs on it's own :/ (@stevekuznetsov could we hook it into a periodic?) |
|
No, plugins are event driven |
|
labeling vendor PRs seems useful on it's own (no matter if we use just this or blockade) the referenced PRs prove the syntax works merge? |
|
/retest @stevekuznetsov anything blocking us from getting those PRs labeled? |
|
/test ci/prow/e2e-aws-upgrade |
|
Nothing wrong with this -- make sure the vendor label you want to use is in the config https://github.com/openshift/release/blob/master/cluster/ci/config/prow/labels.yaml |
|
adding the label here openshift/release#3850 (it was already preexisting) |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
added
the
do-not-merge/invalid-owners-file
There was a problem hiding this comment.
@tnozicka: 1 invalid OWNERS file
In response to this:
If this works, disabling vendor changes because of rebase should be a simple switch in prow merge search query.
/cc @deads2k @stevekuznetsov
@openshift/sig-master
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
tnozicka
force-pushed
the
label-vendor
branch
from
40cc7da
to
c1b353b
Compare
There was a problem hiding this comment.
@tnozicka: 1 invalid OWNERS file
In response to this:
If this works, disabling vendor changes because of rebase should be a simple switch in prow merge search query.
/cc @deads2k @stevekuznetsov
@openshift/sig-master
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
tnozicka
force-pushed
the
label-vendor
branch
from
c1b353b
to
48c63a6
Compare
There was a problem hiding this comment.
@tnozicka: 1 invalid OWNERS file
In response to this:
If this works, disabling vendor changes because of rebase should be a simple switch in prow merge search query.
/cc @deads2k @stevekuznetsov
@openshift/sig-master
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
tnozicka
force-pushed
the
label-vendor
branch
from
48c63a6
to
6cb71f7
Compare
openshift-ci-robot
removed
the
do-not-merge/invalid-owners-file
|
/retest |
|
/assign @stevekuznetsov |
|
What tag? I am not an approver in this repo |
@stevekuznetsov you were the one setting the lgtm flag in #22427 (review) - this PR is already approved |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, stevekuznetsov, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@tnozicka: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
If this works, disabling vendor changes because of rebase should be a simple switch in prow merge search query.
/cc @deads2k @stevekuznetsov
@openshift/sig-master