test/extended: check if there is less than two alerts fired #22513
Conversation
openshift-ci-robot
added
the
size/S
| @@ -150,6 +150,20 @@ var _ = g.Describe("[Feature:Prometheus][Conformance] Prometheus", func() { | |||
| return true, nil | |||
| })).NotTo(o.HaveOccurred()) | |||
| }) | |||
| g.It("should report less than two alerts firing", func() { | |||
There was a problem hiding this comment.
Most of our alerting rules have a for time set. Thereby they can only ever possibly fire after a certain uptime of the cluster.
I don't think waiting for a specific time to pass is an option. Is it possible to run this test at the very end, to increase the probability, that most for ranges are reached.
(For anyone not familiar with Prometheus alerting rules: https://prometheus.io/docs/prometheus/latest/configuration/alerting_rules/)
|
/hold |
paulfantom
force-pushed
the
only_one_alert
branch
2 times, most recently
from
df7cef8
to
c2f35c1
Compare
openshift-ci-robot
added
the
approved
|
/test e2e-aws-upgrade |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, metalmatze, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
In #22512 we are checking if prometheus is firing Watchdog alert which should be the only one fired. This test ensures there are no more firing alerts present.
/CC: @brancz @mxinden @s-urbaniak @squat @metalmatze