Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: drop: Add extra logs for flake analysis #22562

Merged
merged 1 commit into from Apr 18, 2019

Conversation

jsafrane
Copy link
Contributor

Trying to debug https://bugzilla.redhat.com/show_bug.cgi?id=1698829

@wongma7, PTAL

It does extra DescribeInstances after detach, otherwise it just logs stuff and does not prevent the bug in any way.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2019
@wongma7
Copy link
Contributor

wongma7 commented Apr 12, 2019

/lgtm
thx

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@wongma7
Copy link
Contributor

wongma7 commented Apr 12, 2019

/lgtm
just commit msg i see

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

Yes, Travis is now happy

@wongma7
Copy link
Contributor

wongma7 commented Apr 12, 2019

/retest

1 similar comment
@wongma7
Copy link
Contributor

wongma7 commented Apr 12, 2019

/retest

@wongma7
Copy link
Contributor

wongma7 commented Apr 12, 2019

oof, test failing for now because of https://bugzilla.redhat.com/show_bug.cgi?id=1699469.

I ran the statefulset test myself for a couple hours today and didn't see it fail once either. I guess things need to happen in parallel for it to fail. most of the time the 3 pods get scheduled 1 to each worker.

@jsafrane
Copy link
Contributor Author

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c682cfb into openshift:master Apr 18, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2019

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 0e25c5d link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

@wongma7, this is embarrassing, but we don't log level 4 in e2e tests :-(. I got 37 occurrences of "assignment call for already-assigned volume" since this was merged, but all of them are useless.

PR will follow shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants