Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/kube-proxy: update to 4.2, add iptables wrappers #23163

Merged
merged 1 commit into from Jun 20, 2019
Merged

images/kube-proxy: update to 4.2, add iptables wrappers #23163

merged 1 commit into from Jun 20, 2019

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Jun 13, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2019
@squeed
Copy link
Contributor Author

squeed commented Jun 13, 2019

/assign @JacobTanenbaum

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2019
@squeed
Copy link
Contributor Author

squeed commented Jun 14, 2019

/test images

Want to verify that everything builds correctly

@squeed
Copy link
Contributor Author

squeed commented Jun 14, 2019

/test images

Wow, namespaces are cleaned up quickly.

@squeed
Copy link
Contributor Author

squeed commented Jun 14, 2019

What the heck - the hyperkube base image seems to not have hyperkube?

@squeed
Copy link
Contributor Author

squeed commented Jun 14, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2019
@squeed
Copy link
Contributor Author

squeed commented Jun 14, 2019

Want openshift/release#4064 to merge first.

yum install -y --setopt=tsflags=nodocs $INSTALL_PKGS && \
yum clean all && rm -rf /var/cache/*

COPY ./images/sdn/scripts/iptables /usr/sbin/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@squeed for my own knowledge (if you don't mind), what is the rational of having this iptables scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know what mode the host's iptables is in - is it nftables compat mode, or legacy iptables mode? So, we just escape via chroot to the host and execute iptables there.

@squeed
Copy link
Contributor Author

squeed commented Jun 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2019
@squeed
Copy link
Contributor Author

squeed commented Jun 18, 2019

hey @JacobTanenbaum can you take a look?

@JacobTanenbaum
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JacobTanenbaum, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants