New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images/kube-proxy: update to 4.2, add iptables wrappers #23163
images/kube-proxy: update to 4.2, add iptables wrappers #23163
Conversation
/assign @JacobTanenbaum |
/test images Want to verify that everything builds correctly |
/test images Wow, namespaces are cleaned up quickly. |
What the heck - the hyperkube base image seems to not have hyperkube? |
/hold |
Want openshift/release#4064 to merge first. |
yum install -y --setopt=tsflags=nodocs $INSTALL_PKGS && \ | ||
yum clean all && rm -rf /var/cache/* | ||
|
||
COPY ./images/sdn/scripts/iptables /usr/sbin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@squeed for my own knowledge (if you don't mind), what is the rational of having this iptables scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't know what mode the host's iptables is in - is it nftables compat mode, or legacy iptables mode? So, we just escape via chroot to the host and execute iptables there.
/hold cancel |
hey @JacobTanenbaum can you take a look? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JacobTanenbaum, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.