Bug 1723753: OpenShift incorrectly applies RFC 6902 JSON PATCH #23565
Conversation
actually, those changes pin the library to the specific commit - the one that is required by k8s.
openshift-ci-robot
added
the
size/M
| { | ||
| `{ "foo": [ "a", "b", "c", "d", "e" ] }`, | ||
| `[ { "op": "move", "from": "/foo/1", "path": "/foo/2" } ]`, | ||
| `{ "foo": [ "a", "c", "b", "d", "e" ] }`, |
There was a problem hiding this comment.
before this pull, the patch would give a, c, d, b, e - which is incorrect.
|
/lgtm |
|
/assign @mfojtik |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
p0lyn0mial
changed the title
|
@p0lyn0mial: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/test unit |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
this pull pins the library to the specific commit - the one that is required by k8s.