changes openshift-tests to report and error when creating kube client fails #23791

p0lyn0mial · 2019-09-16T10:59:16Z

this pull changes openshift-test to print

openshift-tests excluded test regex is "\\[Disabled:|\\[Disruptive\\]|\\[Skipped\\]|\\[Slow\\]|\\[Flaky\\]|\\[local\\]|\\[Suite:openshift/test-cmd\\]|\\[Skipped:skeleton\\]"
error: invalid configuration: no configuration has been provided

instead of

goroutine 1 [running]:
runtime/debug.Stack(0xc0039959a0, 0x1cbef8d, 0xc000bc4690)
	/usr/local/Cellar/go/1.12.9/libexec/src/runtime/debug/stack.go:24 +0x9d
github.com/openshift/origin/test/extended/util.FatalErr(0x5536180, 0xc00289c520)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/client.go:643 +0x26
github.com/openshift/origin/test/extended/util.InitTest(0x0, 0x0, 0x0)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/test.go:80 +0x5cb
main.initProvider(0x0, 0x0, 0x539fa00, 0x0, 0x5f44342)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:296 +0xe4
main.newRunCommand.func1.1(0x8010105, 0x0)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:127 +0x51
main.mirrorToFile(0xc002ee0c60, 0xc003995c90, 0x5e3a596, 0x4)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:247 +0x98
main.newRunCommand.func1(0xc000133b80, 0xc0003614f0, 0x1, 0x1, 0x0, 0x0)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:126 +0x7d
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).execute(0xc000133b80, 0xc0003612a0, 0x1, 0x1, 0xc000133b80, 0xc0003612a0)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:756 +0x465
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000133900, 0x68d7218, 0xa6060f0, 0xa6060f0)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:846 +0x2ec
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).Execute(...)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:794
main.main.func1(0xc000133900, 0x0, 0x0)
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:71 +0x93
main.main()
	/Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:72 +0x327

Sep 16 12:46:56.658: INFO: invalid configuration: no configuration has been provided
panic:
Your test failed.
Ginkgo panics to prevent subsequent assertions from running.
Normally Ginkgo rescues this panic so you shouldn't see it.

But, if you make an assertion in a goroutine, Ginkgo can't capture the panic.
To circumvent this, you should call

        defer GinkgoRecover()

at the top of the goroutine that caused this panic.
 [recovered]
        panic:
Your test failed.
Ginkgo panics to prevent subsequent assertions from running.
Normally Ginkgo rescues this panic so you shouldn't see it.

But, if you make an assertion in a goroutine, Ginkgo can't capture the panic.
To circumvent this, you should call

        defer GinkgoRecover()

at the top of the goroutine that caused this panic.
goroutine 1 [running]:
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/ginkgowrapper.Fail.func1(0xc0035379a0, 0x4e, 0xa1fdb80, 0x80, 0x284, 0xc002742000, 0x970)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/ginkgowrapper/wrapper.go:63 +0xa1
panic(0x517f8a0, 0x67f4fc0)
        /usr/local/Cellar/go/1.12.9/libexec/src/runtime/panic.go:522 +0x1b5
github.com/openshift/origin/vendor/github.com/onsi/ginkgo.Fail(0xc0035379a0, 0x4e, 0xc00386f878, 0x1, 0x1)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/onsi/ginkgo/ginkgo_dsl.go:259 +0xc8
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/ginkgowrapper.Fail(0xc0035379a0, 0x4e, 0xc00386f920, 0x1, 0x1)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/ginkgowrapper/wrapper.go:67 +0x19b
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework.FailfWithOffset(0x1, 0x5e383c4, 0x2, 0xc00386f990, 0x1, 0x1)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:286 +0x143
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework.Failf(...)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:278
github.com/openshift/origin/test/extended/util.FatalErr(0x5536180, 0xc0035571c0)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/client.go:644 +0x119
github.com/openshift/origin/test/extended/util.InitTest(0x0, 0x0, 0x0)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/test.go:80 +0x5cb
main.initProvider(0x0, 0x0, 0x539fa00, 0x0, 0x5f44342)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:296 +0xe4
main.newRunCommand.func1.1(0x8010107, 0x1)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:127 +0x51
main.mirrorToFile(0xc00243c840, 0xc00386fc90, 0x5e3a596, 0x4)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:247 +0x98
main.newRunCommand.func1(0xc0025d2c80, 0xc0037a8450, 0x1, 0x1, 0x0, 0x0)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:126 +0x7d
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).execute(0xc0025d2c80, 0xc0037a8420, 0x1, 0x1, 0xc0025d2c80, 0xc0037a8420)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:756 +0x465
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc0025d2a00, 0x68d7218, 0xa6060f0, 0xa6060f0)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:846 +0x2ec
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).Execute(...)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:794
main.main.func1(0xc0025d2a00, 0x0, 0x0)
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:71 +0x93
main.main()
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:72 +0x327

p0lyn0mial · 2019-09-16T10:59:39Z

/assign @deads2k

p0lyn0mial · 2019-09-16T20:29:16Z

/retest

deads2k · 2019-09-20T12:37:33Z

/lgtm

openshift-bot · 2019-09-21T23:41:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-21T23:55:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T00:08:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T00:21:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T00:47:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T01:00:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T01:13:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T01:26:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T01:38:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T01:50:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T02:02:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T02:14:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T02:26:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T02:38:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T02:51:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T03:03:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T03:15:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T03:27:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T03:39:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-22T03:51:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T15:24:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T16:03:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T16:29:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T20:36:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T20:52:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T21:03:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T21:15:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T23:12:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T23:25:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T23:38:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-23T23:51:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T00:04:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T00:18:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T00:56:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T01:09:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T01:22:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T01:36:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T01:48:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T02:01:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T02:14:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T03:58:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T04:24:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

p0lyn0mial · 2019-09-24T06:29:04Z

/lgtm cancel

so that the bot doesn't lose his mind.

… fails

deads2k · 2019-10-03T16:36:37Z

/lgtm

openshift-ci-robot · 2019-10-03T16:36:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/OWNERS~~ [deads2k]
~~test/extended/OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2019

openshift-ci-robot assigned deads2k Sep 16, 2019

openshift-ci-robot requested review from bparees and pweil- September 16, 2019 10:59

p0lyn0mial changed the title ~~changes openshift-tests to report and error when creating kube cliet fails~~ changes openshift-tests to report and error when creating kube client fails Sep 16, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2019

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019

changes openshift-tests to report and error when creating kube client…

d88cc07

… fails

p0lyn0mial force-pushed the openshift_test_panics branch from 47cda7f to d88cc07 Compare October 3, 2019 10:50

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019

openshift-merge-robot merged commit 86bee18 into openshift:master Oct 3, 2019

changes openshift-tests to report and error when creating kube client fails #23791

changes openshift-tests to report and error when creating kube client fails #23791

Conversation

p0lyn0mial commented Sep 16, 2019

p0lyn0mial commented Sep 16, 2019

p0lyn0mial commented Sep 16, 2019

deads2k commented Sep 20, 2019

openshift-bot commented Sep 21, 2019

openshift-bot commented Sep 21, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 22, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 23, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

openshift-bot commented Sep 24, 2019

p0lyn0mial commented Sep 24, 2019

deads2k commented Oct 3, 2019

openshift-ci-robot commented Oct 3, 2019