Bug 1749653: (attempt to) fix ECDSA formatted private key usage in route

[Alveel]

An ECDSA private key only specifies "EC PRIVATE KEY", not "ECDSA PRIVATE KEY": https://tools.ietf.org/html/rfc5915

Wouldn't it be better to use MarshalPKCS8PrivateKey in the *KeyBlockVerifier functions? The go documentation specifies

For a more flexible key format which is not EC specific, use MarshalPKCS8PrivateKey.

This is probably incomplete, I tried to set up a test environment to build everything but was having quite some issues there. I'd need to spend quite some more time to set that up. Any/all comments/additions/criticism etc. welcome.

Also, gofmt changed some of the spacing :)

[openshift-ci-robot]

@Alveel: This pull request references Bugzilla bug 1749653, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1749653: (attempt to) fix ECDSA formatted private key usage in route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

Hi @Alveel. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Alveel
To complete the pull request process, please assign ironcladlou
You can assign the PR to them by writing /assign @ironcladlou in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/route/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@Alveel: This pull request references Bugzilla bug 1749653, which is valid.

In response to this:

Bug 1749653: (attempt to) fix ECDSA formatted private key usage in route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ironcladlou]

This appears to be a duplicate of #23918.

[ironcladlou]

Closing as a dupe of #23918. Let me know if I've made a mistake.

/close

[openshift-ci-robot]

@ironcladlou: Closed this PR.

In response to this:

Closing as a dupe of #23918. Let me know if I've made a mistake.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Alveel]

I believe you are correct @ironcladlou. Maybe it's a good idea to internally link the bugzilla reports?

[ironcladlou]

I believe all the bugzillas are appropriately cross-referenced from GitHub. The backport BZs won't link up automatically until https://bugzilla.redhat.com/show_bug.cgi?id=1723400 is verified, then everything should sort out. Thanks!